CBOR-to-JSON: validate UTF-8 content is correct - #332
Open
thiagomacieira wants to merge 2 commits into
Open
Conversation
If `escape_text_string()` fails in `stringify_map_key()`, we would have returned without freeing the contents, but `map_to_json()` doesn't free it on error. Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
We were passing through anything that wasn't a control character, so invalid CBOR text strings were passed through to invalid JSON. As we have the get_utf8() function for cborvalidation.c, let's use it to validate here too. Fixes intel#331. Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
thiagomacieira
force-pushed
the
CBOR_to_JSON_validate_UTF_8_content_is_correct
branch
from
August 4, 2026 18:26
aa66624 to
c6834ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were passing through anything that wasn't a control character, so invalid CBOR text strings were passed through to invalid JSON.
As we have the get_utf8() function for cborvalidation.c, let's use it to validate here too.
Fixes #331.